Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon refresh after create file #35

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

conao3
Copy link
Contributor

@conao3 conao3 commented Mar 17, 2020

Icon refresh after create file and create *-adbices variable and use it.

This PR solves #34.

@seagle0128
Copy link

I think dired-create-directory also should be advised.

@conao3
Copy link
Contributor Author

conao3 commented Mar 17, 2020

Thanks suggestion. added.

@conao3 conao3 force-pushed the fix-icon-when-file-create branch 2 times, most recently from 7bdd087 to 5ef3fdf Compare March 18, 2020 00:06
@conao3
Copy link
Contributor Author

conao3 commented Mar 18, 2020

Solve conflict. Please review @jtbm37 !

@conao3 conao3 force-pushed the fix-icon-when-file-create branch from 5ef3fdf to d795d80 Compare March 20, 2020 03:15
@conao3
Copy link
Contributor Author

conao3 commented Mar 20, 2020

Minor change; rename variable name (*-advices -> *-advice-alist)

@wyuenho
Copy link
Contributor

wyuenho commented Apr 16, 2020

@conao3 are you free to fix the conflicts?

@conao3
Copy link
Contributor Author

conao3 commented Apr 16, 2020

OK, nothing bad. thanks notifying.

@conao3 conao3 force-pushed the fix-icon-when-file-create branch from d795d80 to d35c7f5 Compare April 16, 2020 10:19
@wyuenho
Copy link
Contributor

wyuenho commented May 8, 2020

Ping @jtbm37

@wyuenho
Copy link
Contributor

wyuenho commented Jun 26, 2020

Trying @jtbm37 again

@conao3
Copy link
Contributor Author

conao3 commented Jul 25, 2020

hi, @jtbm37?

wyuenho added a commit to wyuenho/all-the-icons-dired that referenced this pull request Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants